Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2582 Upstream Resource Validator retains deployment classloader #2520

Merged
merged 2 commits into from
Mar 27, 2018
Merged

PAYARA-2582 Upstream Resource Validator retains deployment classloader #2520

merged 2 commits into from
Mar 27, 2018

Conversation

smillidge
Copy link
Contributor

change application to be a local variable to prevent classloader leak when validating resources

@smillidge smillidge modified the milestones: Payara 5.181, Payara 5.182 Mar 11, 2018
@smillidge
Copy link
Contributor Author

jenkins test please

@smillidge smillidge closed this Mar 11, 2018
@smillidge smillidge reopened this Mar 11, 2018
@payara-ci
Copy link
Contributor

Quick build and test failed!

@payara-ci
Copy link
Contributor

Quick build and test passed!

MattGill98
MattGill98 previously requested changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@MattGill98 MattGill98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but I think the DeploymentContext also holds a reference to the application, so would need to be local as well.

@arjantijms arjantijms dismissed MattGill98’s stale review March 27, 2018 12:09

Matt will do a new PR with the requested changes

@arjantijms
Copy link
Contributor

jenkins test please

@payara-ci
Copy link
Contributor

Quick build and test passed!

@arjantijms arjantijms merged commit 4ae5337 into payara:master Mar 27, 2018
@arjantijms arjantijms changed the title PAYARA-2582 … PAYARA-2582 Upstream Resource Validator retains deployment classloader Mar 27, 2018
@payara-ci
Copy link
Contributor

Quick build and test passed!

arjantijms added a commit that referenced this pull request Mar 27, 2018
@arjantijms
Merge pull request #2577 from arjantijms/PAYARA-2582-4
1dd1a29 
PAYARA-2582 … (#2520)
@MattGill98 MattGill98 mentioned this pull request Apr 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

@MattGill98 MattGill98 MattGill98 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Payara 5.182
Development

Successfully merging this pull request may close these issues.
5 participants
@smillidge @payara-ci @arjantijms @MattGill98 @fturizo