-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PAYARA-223 hazelcast eclipselink cache coordination #2666
PAYARA-223 hazelcast eclipselink cache coordination #2666
Conversation
…er and connection.
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
…ast-eclipselink-cache-coordination
Since I am writing a blog and have experience in 2nd level EclipseLink cache coordination, I will take that on, very timely |
jenkins test |
@lprimak That's very good. Looking forward to reading the cache integration blog and examples. Cheers |
jenkins test |
…ast-eclipselink-cache-coordination
@lprimak May I push some improvements to the PR? |
Yes, feel free to do whatever you need. We have some customer issues to deal with this week and next anyway so please make this as good as it can be |
I will do some additional manual testing on Payara Full to make sure it works as expected. |
jenkins test |
Quick build and test passed! |
@smillidge @lprimak I have successfully tested HZ cluster deregistration and registration with:
Please let me know if there is anything around this PR I can be of help with. |
@lprimak @smillidge Should I convert the usage of the stream API and Lambdas to backportable Loops and Interfaces? How about a backport to Payara 4? |
We can support JDK 8 in 4 as this is a separate module by excluding it from JDK 7 builds. |
@lprimak do you think you can get this reviewed before code freeze? |
This is good to go from my perspective as Tech Preview for 5.x. I've built the branch and the reference to the dependency in the JPA packager is enough to get this into the Payara Server distribution. |
Yea I can review by the end of the wekeend |
I have granted @lprimak and @smillidge push access to the branch repo in case anything needs to be pushed while I'm on vacation next week. I'll be checking sporadically if I can help anyhow. |
Great, I should be able to get started in the next few days |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't done a deep look at all the intricate details, but a glance is seems to be okay, certainly for tech preview.
@svendiedrichsen I am trying to write the blog about how to use cache coordination, and have a question: Do you have a simple example on how to use your PR? or a simple blurb about how to use it? |
@lprimak I have a little example project which uses HZ cache coordination under https://github.com/svendiedrichsen/persistence. In essence you use HZ cache coordination by configuring it in your projects persistence.xml as a protocol implementation class:
This will direct Eclipselink to the HZ TransportManager and lead it to instantiate and let it use it. Furthermore you can configure the name of the channel with which Eclipselink will communicate cache changes using a HZ topic of this name. Thus you can partition the communication between different PersistenceUnits:
Does that help in any way? |
Perfect, thanks! |
@smillidge @lprimak Shouldn't this feature be mentioned in the documentation? Maybe somewhere with the public API. https://docs.payara.fish/documentation/payara-server/public-api/ |
It’s in progress. Hasn’t hit the main branch yet |
Looks very nice. Thank you. |
@smillidge @OndrejM
I have created a first implementation of a HazelcastPublishingTransportManager as @OndrejM suggested in #165. It can be used with Payara 5 Micro which I have started twice using the test app.
I have only manually tested the solution using https://github.com/svendiedrichsen/persistence.git
There are three requests to use for querying by id, creating and updating:
Please review and advise:
fixes #165