PAYARA-2781 Exception thrown in logs when shutting down Payara #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test please |
lprimak
previously requested changes
May 30, 2018
|
Feel free to dismiss my review if I am way off base here |
|
Quick build and test failed! |
|
Jenkins test please |
Cousjava
dismissed
lprimak’s stale review
NPE is thrown if JMX isn't started, there aleady is a null check for one point but this is simpler then lots of null checks
|
Quick build and test failed! |
|
Jenkins test please |
|
Quick build and test failed! |
|
Jenkins test please |
Pandrex247
approved these changes
May 31, 2018
|
Quick build and test passed! |
Cousjava
added a commit
to Cousjava/Payara
that referenced
this pull request
May 31, 2018
…a#2799) * PAYARA-2781 Exception thrown in logs when shutting down Payara
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.