Automatically increment busy payara micro http and https ports #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw new NumberFormatException("Not a valid auto bind range"); | ||
| } | ||
| } catch (NumberFormatException nfe) { | ||
| System.err.println(autoBindRangeString |
There was a problem hiding this comment.
Can you throw an IllegalArgument Exception like the other parameters so we can fial-fast
There was a problem hiding this comment.
How do you mean? I designed it so that it doesn't fail if the input for --autoBindRange is incorrect. If it's incorrect, it just reverts back to its default of 5.
There was a problem hiding this comment.
The others "fail fast" if the setting is incorrect to prevent confusion by throwing an IllegalArgumentException
Pandrex247
force-pushed
the
PAYARA-144-Autoincrement-busy-Payara-Micro-Http-Port
branch
from
65e3ec0 to
3adb743
Compare
|
Removed the fallback to default, and rebased against master again. |
|
payara test please |
1 similar comment
|
payara test please |
smillidge
added a commit
that referenced
this pull request
Jul 1, 2015
…-Payara-Micro-Http-Port Automatically increment busy payara micro http and https ports
Pandrex247
deleted the
PAYARA-144-Autoincrement-busy-Payara-Micro-Http-Port
branch
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
May 4, 2021
FISH-1286: Update JDK 11 packages for OSGI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds auto bind functionality to the
--portand--sslPortoptions.Similar to how Hazelcast works, if the HTTP or HTTPS port is busy and auto bind is enabled, it will now try to find an empty port on the next x ports.