CUSTCOM-130 Add payara-web Docker Image #4628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you merge this to your PR, I will approve it :) (I will reduce the copy paste in #4594 after I rebase to merged this) |
|
|
rdebusscher
approved these changes
Apr 17, 2020
There was a problem hiding this comment.
Image size and layers look good.
Probably a test like https://github.com/payara/Payara/blob/master/appserver/extras/docker-images/tests/src/test/java/fish/payara/distributions/docker/PayaraServerFullTest.java required to make sure the image can be started (smoke test)
…-test CUSTCOM-130 Test for the payara/server-web container
dmatej
approved these changes
Apr 17, 2020
|
Jenkins test please |
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jun 15, 2020
CUSTCOM-130 Add payara-web Docker Image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in payara-server-web docker image, missed in original PR.