[FISH-1018] Out of memory redeploy leaks #5081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this could be the first cause of leak
…lasses - anonymous and inner holds implicit reference to parent - this was probably the second cause of leak
|
jenkins test |
lprimak
added
PR: CLA
|
Looks good. Will test it with class loader leak tester (in appserver/tests/payara-samples) to see if it works |
|
Unfortunately, leak tester does not pass, more work needs to be done to determine additional classloader leaks |
|
sgflt
force-pushed
the
4098-out-of-memory-error-redeploy-leaks
branch
from
ed74d0e to
99ed6c8
Compare
|
Tested and before fix count is rising very rapidly. After fix count of classloaders is flipping between 7 and 10. Before: After: |
|
I have double checked results and I can't see any additional classloader leak. |
|
I think the issue is in anonymous inner classes that are part of the WebappClassLoader, I have not had a chance to look any deeper in to this but I think that's the main issue |
lprimak
changed the title
- making sure Server Threads and Timers do not inherit app's context class loaders - making sure app's security contexts don't get propagated to server threads and timers Added correct ear classes to class loader leak tests
lprimak
approved these changes
Jan 26, 2021
|
jenkins test |
lprimak
added a commit
that referenced
this pull request
Feb 5, 2021
* [FISH-1018] Out of memory redeploy leaks (#5081) * #4098 Reduced too broad scope of variable * #4098 Moved field to local variable - this could be the first cause of leak * #4098 Refactored inner and anonymous classes to nested static classes - anonymous and inner holds implicit reference to parent - this was probably the second cause of leak * #4098 Fixed code consistency * Fix more class loader leaks by: - making sure Server Threads and Timers do not inherit app's context class loaders - making sure app's security contexts don't get propagated to server threads and timers Added correct ear classes to class loader leak tests Co-authored-by: lprimak <lenny@flowlogix.com> * [FISH-1018] found more leaks and more reliable leak test (#5102) * found more leaks and more reliable leak test * bump jakarta.el to -p3 patch * tyrus patched update Co-authored-by: Lukáš Kvídera <kvideral@qwsome.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4098
Description
There were multiple causes:
Important Info
Blockers
Testing
New tests
Testing Performed
Testing Environment
Documentation
Notes for Reviewers
Leak in Globals I left untouched.