FISH-5701 fix automated deployment, put command to the right file #5397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalinchan
approved these changes
Sep 1, 2021
|
jenkins test |
AlanRoth
approved these changes
Sep 1, 2021
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
FISH-5701 fix automated deployment, put command to the right file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #5391, application added to $DEPLOY_DIR in docker image is not deployed.
Actually, the fixed file is exactly the same as the related file Payara/appserver/extras/docker-images/server-web/src/main/docker/bin/init_1_generate_deploy_commands.sh, which was OK.
Testing
Testing Performed
In Payara/appserver/extras/docker-images, build docker image:
mvn -pl :server-full-docker-image -am -PBuildExtras -PBuildDockerImages install
Then create directory with clusterjsp.war (or any war), Dockerfile:
FROM payara/server-full
COPY clusterjsp.war $DEPLOY_DIR
Run the docker:
docker run -i --rm --name bwbportal -p 54848:4848 -p 58080:8080 -p 58181:8181 bwbportal
Correct output:
In log:
clusterjsp was successfully deployed in ...
Accessible app:
http://localhost:58080/clusterjsp/