Fish 470 mdb nullpointer when customized mdb pool #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins test |
1 similar comment
|
Jenkins test |
|
Jenkins test |
|
Jenkins test |
Pandrex247
reviewed
Sep 13, 2021
appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/BaseContainer.java
Outdated
Show resolved
Hide resolved
appserver/ejb/ejb-container/src/main/java/com/sun/ejb/containers/BaseContainer.java
Outdated
Show resolved
Hide resolved
appserver/ejb/ejb-full-container/src/main/java/org/glassfish/ejb/mdb/MessageBeanContainer.java
Outdated
Show resolved
Hide resolved
appserver/web/weld-integration/src/main/java/org/glassfish/weld/services/JCDIServiceImpl.java
Outdated
Show resolved
Hide resolved
appserver/web/weld-integration/src/test/java/org/glassfish/weld/WeldActivatorTest.java
Outdated
Show resolved
Hide resolved
|
Jenkins test |
Pandrex247
approved these changes
Sep 13, 2021
pzygielo
reviewed
Sep 13, 2021
appserver/ejb/ejb-container/src/test/java/com/sun/ejb/containers/BaseContainerTest.java
Show resolved
Hide resolved
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Sep 17, 2021
…inter-when-customized-mdb-pool Fish 470 mdb nullpointer when customized mdb pool
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Oct 28, 2021
…inter-when-customized-mdb-pool Fish 470 mdb nullpointer when customized mdb pool
breakponchito
deleted the
FISH-470-mdb-nullpointer-when-customized-mdb-pool
branch
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 10, 2022
…inter-when-customized-mdb-pool Fish 470 mdb nullpointer when customized mdb pool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this is a fix to sanitize the NullPointerException when customizing properties for the MDB
Important Info
Blockers
Testing
New tests
I added unit test for the changes on the following classes: BaseContainer and JCDIServiceImpl. In the case of the unit test for the class MessageBeanContainer I omitted because of the complexity to deal with static methods
Testing Performed
I already tested with unit testing and also on the local environment, please review the following comment to verify the result of tests: https://payara.atlassian.net/browse/FISH-470?focusedCommentId=57455
Testing Environment
Windows 10 with JDK 8
Documentation
Notes for Reviewers