FISH-5800 Jaspic Uses Unexported Package in 'java.base' Module #5470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arjantijms <arjan.tijms@gmail.com>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
Signed-off-by: Andrew Pielage <andrew.pielage@payara.fish>
|
Jenkins test please |
Pandrex247
commented
Oct 26, 2021
| } | ||
|
|
||
| // map id to Intercept | ||
| intEntry.idMap.put(id, idEntry); | ||
| } | ||
|
|
||
| private String expand(String rawProperty) { | ||
| Matcher propertyMatcher = PROPERTY_PATTERN.matcher(rawProperty); | ||
| StringBuffer propertyBuilder = new StringBuffer(); |
There was a problem hiding this comment.
Was StringBuilder upstream, but Matcher.appendReplacement uses StringBuffer in JDK8.
There was a problem hiding this comment.
StringBuffer is synchronized, e.g. necessarily slower if not used among threads.
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
|
Jenkins test please |
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Nov 18, 2021
FISH-5800 Jaspic Uses Unexported Package in 'java.base' Module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using JDK 17 Payara Micro would throw an exception about java.base not exporting the
sun.security.utilpackage.This PR brings in the changes made upstream in GlassFish, and adjusts it to fit in our code base: eclipse-ee4j/glassfish#23339
Important Info
Blockers
None
Testing
New tests
None
Testing Performed
Build the server (JDK 8)
Started Payara Micro and deployed reproducer app from Jira and poked the endpoint (JDK 17) - no error
Started Payara Micro and deployed reproducer app from Jira and poked the endpoint (JDK 8) - no error
Started Payara Micro and deployed reproducer app from Jira and poked the endpoint (JDK 11) - no error
Testing Environment
Windows 10.
Zulu JDK 8.0.312, 11.0.13, and 17.0.1
Documentation
N/A
Notes for Reviewers
Haven't poked the server past just loading the admin console, but no purple dancing elephants as to why this would break anything.