FISH-5851 Prevent NullPointerException in com.sun.jts.CosTransactions.RecoveryManager
#5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a copy of the EventSemaphore before checking its state.
AlanRoth
added
PR: Awaiting CLA
|
Hi, @chrjohn Thank you for the PR, we're happy to receive your contribution, before we can proceed you will need to sign the CLA and send it to us. Thank you, |
|
jenkins test please |
pdudits
approved these changes
Nov 9, 2021
|
@pdudits , thanks, will do. |
AlanRoth
changed the title
com.sun.jts.CosTransactions.RecoveryManagercom.sun.jts.CosTransactions.RecoveryManager
smillidge
added
PR: CLA
|
Thanks we have the CLA |
|
jenkins test please |
aubi
pushed a commit
to aubi/Payara
that referenced
this pull request
Jan 3, 2022
FISH-5851 Prevent NullPointerException in `com.sun.jts.CosTransactions.RecoveryManager`
JamesHillyard
pushed a commit
to JamesHillyard/Payara
that referenced
this pull request
Jan 24, 2022
FISH-5851 Prevent NullPointerException in `com.sun.jts.CosTransactions.RecoveryManager`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5491
Make a copy of the EventSemaphore before accessing it.
Description
Prevents NPE in
com.sun.jts.CosTransactions.RecoveryManagerby making a copy of theEventSemaphore. This was suggested by @pdudits in https://forum.payara.fish/t/nullpointerexception-in-com-sun-jts-costransactions-recoverymanager-when-restoring-ejb-timers/81Important Info
Testing
This is a race condition which occurs very rarely. We only encountered this once in several years.
However, if anyone has an idea for a test I'd be happy to work on it.
Testing Performed
n/a
Testing Environment
n/a
Documentation
n/a
Notes for Reviewers
n/a