FISH-5879 The 'stop-deployment-group --kill=true' command does not work with custom Node Directory #5548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JamesHillyard <james.hillyard@payara.fish>
|
Jenkins test please |
Pandrex247
approved these changes
Jan 7, 2022
JamesHillyard
added a commit
to JamesHillyard/Payara
that referenced
this pull request
Jan 24, 2022
FISH-5879 The 'stop-deployment-group --kill=true' command does not work with custom Node Directory
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Jan 28, 2022
FISH-5879 The 'stop-deployment-group --kill=true' command does not work with custom Node Directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug fix where using a custom node directory would result in
Node directory ... does not exist or is not a valid node directoryas it would always look at the default directory when executingasadmin stop-local-instanceas part of theasadmin stop-deployment-groupcommand.Important Info
Testing
Testing Performed
Manually tested with reproducer on the ticket using: New node in custom directory, default node and New node in default directory.
Testing Environment
Windows 10, JDK 8, Maven 3.6.3
Documentation
None.
Notes for Reviewers
None.