FISH-6858 JBoss Class File Writer 1.3.0 #6409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Pielage <pandrex247@hotmail.com>
|
Jenkins test please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the JBoss Class File Writer to 1.3.0.Final with amendments.
The vanilla 1.3.0.Final release has malformed OSGi, with the osgi.ee filter being set to UNKNOWN. This is fixed by using a more recent version of the Maven Bundle plugin.
This however also starts importing java.* packages by default (the ones from the JDK), which we don't currently support, so there's also an additional change to make it so that these packages are excluded.
Important Info
Blockers
payara/patched-src-jboss-classfilewriter#1
Testing
New tests
None
Testing Performed
mkdir D:\Downloads\FISH-6858mvn clean install "-Dmaven.repo.local=D:\Downloads\FISH-6858"mvn clean install "-Dmaven.repo.local=D:\Downloads\FISH-6858" -Djboss.classfilewriter.version=1.3.0.Final.payara-p2-SNAPSHOTasadmin start-databasemvn clean verify "-Dmaven.repo.local=D:\Downloads\FISH-6858" "-Dpayara.version=6.2023.10-SNAPSHOT" -Dpayara_domain=domain1 "-Ppayara-server-remote,stable"Testing Environment
Windows 11, Zulu 11
Documentation
Third party license file updated in PR.
Notes for Reviewers
None