FISH-8681 upgrade nimbus jose jwt #6823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…T' into FISH-8681-Upgrate-Nimbus-Jose-JWT
Pandrex247
approved these changes
Jul 22, 2024
|
Jenkins test please |
NotedSalmon
dismissed
aubi’s stale review
Resolved, cannot mark it as resolved...
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Aug 13, 2024
…bus-Jose-JWT FISH-8681 upgrade nimbus jose jwt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FISH-8681 upgrade Nimbus Jose JWT
Description
Test samples were failing as the newer versions of Nimbus Jose JWT does not include the jcip annotations, added the dependency to the test-utils pom and also in the Payara-samples pom.
Important Info
Blockers
Testing
New tests
Testing Performed
Ran the tests and the build was successful
Testing Environment
Documentation
Notes for Reviewers
I wasn't too sure if I should be removing the artifact reference in appserver/packager/external/jcip/pom line 79.