Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FISH-9111 stax2-api dependency. #6869

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

Viii3
Copy link
Member

@Viii3 Viii3 commented Aug 7, 2024

Description

  • Resolves FISH-9111

Important Info

Blockers

Testing

New tests

Reproducer can be found in this repository.

Testing Performed

Built Payara and tested against the reproducer.

Testing Environment

Maven version: 3.9.6
Java version: 21.0.3, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

Documentation

Notes for Reviewers

@Viii3 Viii3 requested a review from pdudits August 7, 2024 14:55
@breakponchito
Copy link
Contributor

breakponchito commented Aug 8, 2024

Tested with Payara 6, without this change i can see the error with Payara micro using my own reproducer::
image

with the fix now I can access the endpoint:
image

@breakponchito breakponchito self-requested a review August 8, 2024 21:41
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breakponchito breakponchito self-requested a review August 8, 2024 21:55
Copy link
Contributor

@breakponchito breakponchito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Viii3 Viii3 merged commit feceb88 into payara:main Aug 13, 2024
1 check passed
@Viii3 Viii3 deleted the FISH-9111-Community6 branch September 3, 2024 08:42
Pandrex247 pushed a commit to Pandrex247/Payara that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants