FISH-6579 Hide ssl tab when security is disabled #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
approved these changes
Aug 21, 2024
Pandrex247
pushed a commit
to Pandrex247/Payara
that referenced
this pull request
Sep 16, 2024
FISH-6579 Hide ssl tab when security is disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the admin console, the SSL settings tab should be hidden when security is disabled.
This PR gets the securityEnabled attribute and renders the tab if security is enabled.
Important Info
Blockers
n/a
Testing
New tests
n/a
Testing Performed
Manual testing, started admin console, visited server-config -> http listeners, network listeners and protocols.
Verified that the ssl tab was rendered correctly based on Security being enabled.
Testing Environment
Apache Maven 3.9.8 (36645f6c9b5079805ea5009217e36f2cffd34256)
Maven home: /Users/kalinchan/Library/apache-maven-3.9.8
Java version: 11.0.23, vendor: Azul Systems, Inc., runtime: /Users/kalinchan/.sdkman/candidates/java/11.0.23-zulu/zulu-11.jdk/Contents/Home
Default locale: en_GB, platform encoding: UTF-8
OS name: "mac os x", version: "14.6.1", arch: "aarch64", family: "mac"
Documentation
n/a
Notes for Reviewers
n/a