Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYARA-2603 Grizzly Autobinding #5

Merged
merged 2 commits into from
Apr 3, 2018
Merged

PAYARA-2603 Grizzly Autobinding #5

merged 2 commits into from
Apr 3, 2018

Conversation

MattGill98
Copy link

Adapted current PortRange functionality to allow it to function similarly to --autoBindHttp in Payara Micro.

@MattGill98
Copy link
Author

NetworkListener and TCPNIOTransport provided bind methods with a specified PortRange that made the server pick a random port in the range, then bind to each in a loop until one was bound. This is now configurable to start at the port range start, allowing more expected autobind behaviour. Old functionality is maintained by default.

Pandrex247
Pandrex247 approved these changes Apr 3, 2018
View reviewed changes
Copy link
Member

@Pandrex247 Pandrex247 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but looks fine

@MattGill98 MattGill98 merged commit ed38157 into payara:master Apr 3, 2018
@MattGill98 MattGill98 deleted the PAYARA-2603-Grizzly-Autobinding branch June 18, 2018 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pandrex247 Pandrex247 Pandrex247 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattGill98 @Pandrex247