forked from javaee/metro-wsit
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FISH-5811 Upgrade Santuario to version 2.2.3 #11
Merged
JamesHillyard
merged 6 commits into
payara:2.4.3.payara-maintenance
from
JamesHillyard:FISH-5811
Dec 2, 2021
Merged
FISH-5811 Upgrade Santuario to version 2.2.3 #11
JamesHillyard
merged 6 commits into
payara:2.4.3.payara-maintenance
from
JamesHillyard:FISH-5811
Dec 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/ResolverId.java
Outdated
Show resolved
Hide resolved
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/ResolverId.java
Outdated
Show resolved
Hide resolved
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/URIResolver.java
Outdated
Show resolved
Hide resolved
...s-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/transform/AttachmentCompleteTransform.java
Outdated
Show resolved
Hide resolved
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/URIResolver.java
Outdated
Show resolved
Hide resolved
...x/wssx-impl/src/main/java/com/sun/xml/wss/impl/transform/AttachmentContentOnlyTransform.java
Outdated
Show resolved
Hide resolved
breakponchito
approved these changes
Nov 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to confirm the cases I commented on the code, but in general LGTM
Pandrex247
requested changes
Nov 26, 2021
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/ResolverId.java
Outdated
Show resolved
Hide resolved
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/ResolverId.java
Outdated
Show resolved
Hide resolved
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/URIResolver.java
Outdated
Show resolved
Hide resolved
wsit/ws-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/resolver/URIResolver.java
Outdated
Show resolved
Hide resolved
...s-sx/wssx-impl/src/main/java/com/sun/xml/wss/impl/transform/AttachmentCompleteTransform.java
Outdated
Show resolved
Hide resolved
...x/wssx-impl/src/main/java/com/sun/xml/wss/impl/transform/AttachmentContentOnlyTransform.java
Outdated
Show resolved
Hide resolved
Pandrex247
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CVE-2021-40690 identified a security issue with Santuario versions prior to 2.2.3 and 2.1.7. This PR updates our patched repo to 2.2.3 which also can run on JDK14+
This also implements some necessary methods and changes for compilation from changes in Apache Santuario between 1.5.8 and 2.2.3
Tested the server starts and admin console loads Windows 10 JDK 8 and JDK17.
When approved 2.4.3.payara-p6 will be created containing these changes