Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] Align commands with the chosen driver. #38

Merged
merged 24 commits into from
Jan 22, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Jan 12, 2024

What does this PR do? 🤖

  • Renames the service:install command to orchestrate:service.
  • Renames the service:provider command to orchestrate:provider.
  • Asks what driver should be used to orchestrate the service.
  • Removes providers & merchants from the service config when database driver is chosen.
  • Generates migration if database driver is chosen.
  • Updates tests structure for using different drivers and test mode.

Does this relate to any issue? 🔗

Closes #20 & consider this part 1 of #39.

@r-kujawa r-kujawa force-pushed the enhancement-20-align_commands_with_driver branch from 5e6f2d3 to 6a04a23 Compare January 12, 2024 14:02
Copy link

cloudflare-workers-and-pages bot commented Jan 12, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc8851b
Status: ✅  Deploy successful!
Preview URL: https://6b601242.orchestration.pages.dev
Branch Preview URL: https://enhancement-20-align-command.orchestration.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9de10af) 88.62% compared to head (bc8851b) 90.81%.

Files Patch % Lines
src/ServiceDriver.php 0.00% 2 Missing ⚠️
src/Console/Commands/OrchestrateService.php 97.77% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #38      +/-   ##
============================================
+ Coverage     88.62%   90.81%   +2.18%     
- Complexity      186      190       +4     
============================================
  Files            22       22              
  Lines           589      653      +64     
============================================
+ Hits            522      593      +71     
+ Misses           67       60       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa changed the title 🚧 [1.0] Align commands with the chosen driver. [1.0] Align commands with the chosen driver. Jan 22, 2024
@r-kujawa r-kujawa merged commit 9192746 into master Jan 22, 2024
7 checks passed
@r-kujawa r-kujawa deleted the enhancement-20-align_commands_with_driver branch January 22, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update commands to align with database driver if that is the chosen one.
2 participants