Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Orchestrate services via config only. #40

Merged
merged 8 commits into from
Feb 2, 2024

Conversation

r-kujawa
Copy link
Contributor

What does this PR do? 🤖

  • Removes ability to orchestrate services via multiple drivers.
  • Deletes the Service::class model & removes the services table from the base migration.
  • Removes any additional complexity that was required to allow multiple drivers orchestrating the services.

Any background context you would like to provide? 🚧

This ability is being removed is because of the confusion it may cause and it didn't make much sense in the first place.

Does this relate to any issue? 🔗

Closes #39

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9192746) 90.81% compared to head (6110120) 92.25%.

Files Patch % Lines
src/Models/Merchant.php 50.00% 1 Missing ⚠️
src/Service.php 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
+ Coverage     90.81%   92.25%   +1.44%     
+ Complexity      190      181       -9     
============================================
  Files            22       21       -1     
  Lines           653      633      -20     
============================================
- Hits            593      584       -9     
+ Misses           60       49      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cloudflare-workers-and-pages bot commented Jan 26, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6110120
Status:⚡️  Build in progress...

View logs

@r-kujawa r-kujawa marked this pull request as ready for review February 2, 2024 13:41
@r-kujawa r-kujawa merged commit 4c572f7 into master Feb 2, 2024
6 of 7 checks passed
@r-kujawa r-kujawa deleted the enhancement-39-orchestrate_using_config branch February 2, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Services should always be orchestrated using config.
2 participants