Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Fix config bug. #54

Merged
merged 5 commits into from
Mar 19, 2024
Merged

[1.x] Fix config bug. #54

merged 5 commits into from
Mar 19, 2024

Conversation

r-kujawa
Copy link
Contributor

@r-kujawa r-kujawa commented Mar 17, 2024

What does this PR do? 🤖

  • Set recently generated service config during execution to not break later flows.

Does this relate to any issue? 🔗

Closes #52

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.28%. Comparing base (0521399) to head (1d0bab9).

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x      #54      +/-   ##
============================================
+ Coverage     92.27%   92.28%   +0.01%     
- Complexity      181      182       +1     
============================================
  Files            21       21              
  Lines           634      635       +1     
============================================
+ Hits            585      586       +1     
  Misses           49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@r-kujawa r-kujawa merged commit f0b3129 into 1.x Mar 19, 2024
6 checks passed
@r-kujawa r-kujawa deleted the bug-52-orchestrate_service_config branch March 19, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when running php artisan orchestrate:service.
2 participants