-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hide publish button based on permissions #4203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRibbens
requested review from
jmikrut,
jacobsfletch,
JarrodMFlesch and
denolfe
as code owners
November 17, 2023 19:56
@@ -58,6 +58,8 @@ export const DocumentControls: React.FC<{ | |||
|
|||
const hasCreatePermission = 'create' in permissions && permissions.create?.permission | |||
const hasDeletePermission = 'delete' in permissions && permissions.delete?.permission | |||
const hasPublishPermission = | |||
'publish' in permissions && permissions.fields?._status?.update?.permission |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a WIP, just wanted to note that publish
does not exist on the permissions
type as of right now.
payload/packages/payload/src/auth/types.ts
Lines 35 to 53 in 724d80b
export type CollectionPermission = { | |
create: Permission | |
delete: Permission | |
fields: { | |
[fieldName: string]: FieldPermissions | |
} | |
read: Permission | |
readVersions?: Permission | |
update: Permission | |
} | |
export type GlobalPermission = { | |
fields: { | |
[fieldName: string]: FieldPermissions | |
} | |
read: Permission | |
readVersions?: Permission | |
update: Permission | |
} |
DanRibbens
changed the title
feat: WIP hide publish button based on permissions
feat: hide publish button based on permissions
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the publish button when access control does not allow a user to publish collections and globals.
Type of change
Checklist: