This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
feat: add serverside validation to form submission #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original
What it does:
How it does this:
What it does not do:
Performance considerations:
Update
Looking at the
beforeValidate
hook, it does not provide an easy way to through field level validation errors. With this in mind, I thought of a solution that keeps validation in the field level, and uses thebeforeValidate
hook in the spirit it was intended-- to prepare for validation.Required Fields:
In the updated implementation I've added a
beforeValidate
hook which looks of the form, iterates through its fields, and adds an empty record for any field which was not included in the submission. This allows the field level validator to run on these missing fields, and evaluate if they should be treated as required down the road.Invalid Form Names:
beforeValidate
hook which will return an error if no form is found. It may be preferable to do this validation in the field level too, I'll leave this up to the reviewers discretion.Performance: