-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update axo loader library #2355
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2355 +/- ##
==========================================
+ Coverage 51.32% 58.00% +6.67%
==========================================
Files 104 153 +49
Lines 2038 12232 +10194
Branches 604 742 +138
==========================================
+ Hits 1046 7095 +6049
- Misses 889 5041 +4152
+ Partials 103 96 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a minor comment, otherwise looks good.
@@ -1,5 +1,5 @@ | |||
/* @flow */ | |||
import { loadAxo } from "@paypal/connect-loader-component"; | |||
import { loadAxo } from "@paypal/accelerated-checkout-loader/dist/loader.esm"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make the loader a top level export from this package? Bit worried that importing nested dependencies can create issues with future refactorings in this component.
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Reverts the revert. This is re-adding the updated axo library