Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update axo loader library #2355

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wsbrunson
Copy link
Member

@wsbrunson wsbrunson commented Mar 6, 2024

Reverts the revert. This is re-adding the updated axo library

@wsbrunson wsbrunson requested a review from a team as a code owner March 6, 2024 16:02
@wsbrunson wsbrunson changed the title Revert "Revert "update axo loader library"" update axo loader library Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.00%. Comparing base (20c9729) to head (3a7e75a).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2355      +/-   ##
==========================================
+ Coverage   51.32%   58.00%   +6.67%     
==========================================
  Files         104      153      +49     
  Lines        2038    12232   +10194     
  Branches      604      742     +138     
==========================================
+ Hits         1046     7095    +6049     
- Misses        889     5041    +4152     
+ Partials      103       96       -7     
Flag Coverage Δ
jest 32.12% <ø> (+0.12%) ⬆️
karma 50.17% <ø> (+0.11%) ⬆️
vitest 54.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ravishekhar ravishekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor comment, otherwise looks good.

@@ -1,5 +1,5 @@
/* @flow */
import { loadAxo } from "@paypal/connect-loader-component";
import { loadAxo } from "@paypal/accelerated-checkout-loader/dist/loader.esm";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the loader a top level export from this package? Bit worried that importing nested dependencies can create issues with future refactorings in this component.

Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added Stale and removed Stale labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants