[DO NOT MERGE] Increase minimum label height to 20px #2422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Co-authored by @gcaven
Hello PayPal SDK team 👋 We are trying to render a PayPal button using the
disableMaxHeight: true
anddisableMaxWidth: true
params so the PayPal button sizes according to the container.We noticed the PayPal logo scales proportionately to the container size, but at small container sizes, the PayPal logo gets very small such that it looks inconsistent to other branded buttons on the page- please see screenshots below.
@westeezy helped us and pointed us out to where the
.paypal-button-label-container
CSS is generated. However,labelHeight
is dynamic and used in a lot of places, so we were curious if you could help us make sense of whether this fits in your product requirements and move this forward. Many thanks in advance 🙏Reproduction Steps (if applicable)
style
param, setdisableMaxHeight: true
anddisableMaxWidth: true
Screenshots (if applicable)
Current state
Desired state
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!