Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/more cdn logos #92

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Feature/more cdn logos #92

merged 4 commits into from
Feb 3, 2023

Conversation

dtjones404
Copy link
Contributor

Remaining logos/marks have been refactored to enable CDN hosting experiment, completing the work started in #89. buildLogos.js and some util functions have been refactored slightly to allow for logos with no color variants.

@dtjones404 dtjones404 requested a review from a team as a code owner February 3, 2023 15:19
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 70.31% // Head: 73.27% // Increases project coverage by +2.95% 🎉

Coverage data is based on head (b0affea) compared to base (ba73b21).
Patch coverage: 84.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   70.31%   73.27%   +2.95%     
==========================================
  Files          41       41              
  Lines         283      348      +65     
  Branches       35       36       +1     
==========================================
+ Hits          199      255      +56     
- Misses         81       90       +9     
  Partials        3        3              
Impacted Files Coverage Δ
src/logos/credit/mark.jsx 16.66% <20.00%> (+16.66%) ⬆️
src/logos/paypal/mark.jsx 16.66% <20.00%> (+16.66%) ⬆️
src/logos/bank/glyph/logo.jsx 25.00% <33.33%> (+5.00%) ⬆️
src/logos/card/glyph/logo.jsx 25.00% <33.33%> (+5.00%) ⬆️
src/constants.js 100.00% <100.00%> (ø)
src/lib/util.js 85.71% <100.00%> (+10.71%) ⬆️
src/logos/applepay/mark.jsx 100.00% <100.00%> (ø)
src/logos/card/amex/logo.jsx 85.71% <100.00%> (+19.04%) ⬆️
src/logos/card/discover/logo.jsx 85.71% <100.00%> (+19.04%) ⬆️
src/logos/card/elo/logo.jsx 85.71% <100.00%> (+19.04%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gregjopa gregjopa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @dtjones404! 💯

@gregjopa gregjopa merged commit ae38cc6 into main Feb 3, 2023
@gregjopa gregjopa deleted the feature/more-cdn-logos branch February 3, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants