Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Data script tag insertion doesn't use regex #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jjacobskind
Copy link

I was getting an invalid checksum error when rendering a page that contained a series of dollar signs ($$$). Since dollar signs are a special character in regex, every two dollar signs were being combined into a single escaped dollar sign (ex: $$$ -> $$).

@samsel
Copy link
Contributor

samsel commented Mar 2, 2017

@jjacobskind what are your thoughts on adding some more tests around this?

@jjacobskind
Copy link
Author

You mean just testing that special regex characters no longer cause an error? I can do that.

@samsel
Copy link
Contributor

samsel commented Apr 9, 2017

yes please

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants