Add staged CABLE driver for CABLE configurations #461
Conversation
staged_cable driver works for running arbitrary staged CABLE spin-up configurations.
Whyborn
changed the title
Whyborn
changed the title
|
I'll add some tests before requesting another review. |
|
Are you ready for another review @Whyborn? |
|
I had requested another one, but I have been doing some thinking since the Payu workshop session to improve the handling of restarts. I'll cancel the current request and add a new one after I make (or not make) some changes. |
The files retrieved by get_prior_restart_files are automatically prepended by the experiment restart directory, which is the most recent restart. Adding '..' to redirect to the older restart directories is also not an option, as the generated links will inherit the same redirection. Also handed situation where user only provides a stage namelist, with no corresponding master.
|
I've made some adjustments to the way we retrieve the restarts, see the unresolved conversation. I've added tests to capture most of the desired functionality, but I was struggling to build a good test for retrieving restarts. |
There was a problem hiding this comment.
I haven't looked at the tests and I'm running out of time so I'll send what I've picked up.
I would refactor _prepare_stage(). I don't like that it calls _apply_stage_namelists(). I would transform _prepare_stage() into a _get_stage_name() function that returns the current stage name. Then call that from _apply_stage_namelists() or from within setup().
Then I would introduce a deal_with_configuration_log() function (name to be determine) that is called at the end of setup() and deals with saving the configuration log file (call the function you have for that) and copying it to the work directory.
One final comment for @aidanheerdegen , do you have any aspiration to use Pathlib instead of os.path in payu? If so, maybe it's a bad idea to introduce a new driver based on os.path. Your call @aidanheerdegen .
|
I think I'm at the end of my utility as a reviewer. I see @ccarouge has a few more suggestions, but after that probably best to merge it and start using it and iterate if there are problems, or improvements required. You're not touching any other drivers, so it's fairly side-effect free and you can test it, as can others. |
There was a problem hiding this comment.
I've approved as Claire is away in case you're ready to merge @Whyborn
Whyborn
changed the title
This driver is intended to facilitate spin-up CABLE configurations, which involve usually many stages with differing science configurations. An example experiment exists here, with some documentation: Staged_CABLE