Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override yatm model class method for prior restarts #531

Merged

Conversation

jo-basevi
Copy link
Collaborator

Implements solution described here: #523 (comment), which was to add an override the parent class get_prior_restart_files in yatm, to return just an empty array. This is to prevent error messaging on a missing prior restart directory when yatm driver does not require any.

Closes #523

@pep8speaks
Copy link

Hello @jo-basevi! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 7:1: E302 expected 2 blank lines, found 1

@jo-basevi jo-basevi marked this pull request as ready for review October 15, 2024 01:03
@coveralls
Copy link

Coverage Status

coverage: 58.546% (+0.2%) from 58.332%
when pulling 6143912 on ACCESS-NRI:523-yatm-get-prior-retart-files
into 2faf9e7 on payu-org:master.

Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

test/models/test_yatm.py Show resolved Hide resolved
@aidanheerdegen aidanheerdegen merged commit 7c885b8 into payu-org:master Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACCESS-OM2 driver insists on their being an atmosphere subdirectory when restarting
4 participants