Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! 👋 . I noticed that the tests on this PR import-js#2121 were passing with and without the bug fix, so I adjusted them so that they pick up the regression correctly.
The particular bug only shows up when:
The test previously was checking for a package that was listed in package.json, so that meant it passed regardless of the bug being fixed or not.
I also made a small adjustment to the code, I'll comment it below.