some interesting static check warnings

[jxsl13]

Some filtered staticcheck warnings that might be interesting

datamodel/high/base/schema.go:234:2: empty branch (SA9003)

datamodel/low/extraction_functions.go:121:89: error should be returned as the last argument (ST1008)


datamodel/low/reference.go:164:2: ineffective assignment to field NodeReference.Reference (SA4005)
datamodel/low/reference.go:176:6: ineffective assignment to field NodeReference.ReferenceNode (SA4005)
datamodel/low/reference.go:257:2: ineffective assignment to field ValueReference.Reference (SA4005)


datamodel/low/extraction_functions.go:487:5: this value of rv is never used (SA4006)
datamodel/low/extraction_functions.go:494:4: this value of referenceValue is never used (SA4006)
datamodel/low/extraction_functions.go:505:7: this value of rvt is never used (SA4006)
datamodel/low/extraction_functions.go:510:6: this value of referenceValue is never used (SA4006)
index/extract_refs.go:355:3: this value of seenPath is never used (SA4006)

[daveshanley]

Which tool are you using to generate this report?

[jxsl13]

staticcheck

[jxsl13]

it is part of: https://github.com/dominikh/go-tools
and is usually part of the VS Code Go extension.

[daveshanley]

I don't use VSCode, so I will try the tool out manually.

[daveshanley]

All the static check warnings have now been cleaned up, the only ones left are cosmetic elements, or signature changes that are breaking for no reason. Effective v0.15.6