Missing Line and Column Information in model.ChangeContext for Enum Changes fix #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed) object, added schema tests for model.ChangeContext line and column on enum changes.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
- Coverage 99.62% 99.60% -0.02%
==========================================
Files 160 160
Lines 11880 11882 +2
==========================================
Hits 11835 11835
- Misses 45 47 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
daveshanley
approved these changes
Jan 11, 2024
|
The code coverage issue is a glitch with codecov, all code is covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for issue #231
I have addressed the issue by implementing a simple fix: removing the encoding from the toString function. However, it became apparent that this alone was insufficient. The toString function is crucial when storing the node.Yaml enum object string value as a key in a map, which is used for comparison between the right and left sides.
To mitigate this issue, I have modified the toString function to return the encoded string without including the column and line information. To prevent the loss of the original object's line and column data, I have utilized a copy of the object. This ensures that the comparison is not adversely affected by the line and column information, while still preserving the integrity of the original object's data.