Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #235

Merged
merged 21 commits into from
Jan 18, 2024
Merged

Windows support #235

merged 21 commits into from
Jan 18, 2024

Conversation

daveshanley
Copy link
Member

@daveshanley daveshanley commented Jan 15, 2024

Adds full windows support to libopenapi, and any application using it. The index module can now make sense of windows paths and drives.

New Feature

A new bundler module has been added that contains two new functions. BundleDocument() and BundleBytes()

Both methods will render out a new OpenAPI file has all references inlined, all external references, everything.

If you have been looking for a simple way to create a single OpenAPI document, from an whole bunch of referenced files? Then the bundler is what you need.

Bundling specs docs

Signed-off-by: quobix <dave@quobix.com>

formatted code

Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
discovered glitch when reworking test for pipeline

Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f4647af) 99.60% compared to head (5f41b3d) 99.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   99.60%   99.62%   +0.01%     
==========================================
  Files         160      162       +2     
  Lines       11890    11967      +77     
==========================================
+ Hits        11843    11922      +79     
+ Misses         47       45       -2     
Flag Coverage Δ
unittests 99.62% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

will be an effort to rewrit logic for windows specifically in these use cases
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
removed dead code after abs path change on lookup

Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
resolves a v3 document or a model into a single document.

Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Also added map conversion utilities based on reported vacuum error daveshanley/vacuum#417
also prevented the bundler from inlining root references.

Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
@daveshanley daveshanley merged commit e0f0f38 into main Jan 18, 2024
4 checks passed
@daveshanley daveshanley deleted the windows-support branch January 18, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant