v0.15.5 #245
Merged
v0.15.5 #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rolodex was running away and locking up vacuum. Signed-off-by: quobix <dave@quobix.com>
|
hmm. I should really run my own tests before submitting a PR. |
The remote file loader is no longer going to care about anything other that explicit http links, trying to figure out where things should be loaded form using an overridden basepath and host is too complex of a usecase that I cannot be sure even exists. Signed-off-by: quobix <dave@quobix.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
=======================================
Coverage 99.61% 99.62%
=======================================
Files 162 162
Lines 11991 11990 -1
=======================================
Hits 11945 11945
+ Misses 46 45 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Signed-off-by: quobix <dave@quobix.com>
Not sure why I built the original code the way it was, but it’s now a simplified query without stripping out, or manipulating the path in anyway, the rest of the code that follows after handles the query correctly. Signed-off-by: quobix <dave@quobix.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix release, no new features, no breaking changes.
Addresses issues:
An issue discovered where the rolodex was running away and locking cores (locked our 32vpcu instance).