-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add server variable extensions #326
feat: add server variable extensions #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for your contribution.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=======================================
Coverage 99.63% 99.64%
=======================================
Files 164 164
Lines 16586 16674 +88
=======================================
+ Hits 16526 16614 +88
Misses 55 55
Partials 5 5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Two lines to cover and it's good to go. |
9815681
to
0b94339
Compare
0b94339
to
45c9c61
Compare
Fix the tests and I can add this in! |
Allow to use server variable extension: