Skip to content

Commit

Permalink
roachtest: remove wait loop in backup2TB roachtest
Browse files Browse the repository at this point in the history
Previously a wait loop was needed in the backup2TB roachtest because the
test was reporting the table as offline when it shouldn't have seen it
as OFFLINE. This was fixed by cockroachdb#40996, and therefore we should no longer
need this wait loop.

Release justification: Only touches tests.

Release note: None
  • Loading branch information
pbardea committed Sep 23, 2019
1 parent 9d81b08 commit db52476
Showing 1 changed file with 0 additions and 16 deletions.
16 changes: 0 additions & 16 deletions pkg/cmd/roachtest/backup.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,6 @@ func registerBackup(r *testRegistry) {
"--db=bank", "--payload-bytes=10240", "--ranges=0", "--csv-server", "http://localhost:8081",
fmt.Sprintf("--rows=%d", rows), "--seed=1", "{pgurl:1}")

// NB: without this delay, the BACKUP operation sometimes claims that
// bank.bank doesn't exist, probably due to some gossip propagation
// delay.
//
// See https://github.com/cockroachdb/cockroach/issues/36841.
for i := 0; i < 5; i++ {
_, err := c.Conn(ctx, 1).ExecContext(ctx, "SELECT * FROM bank.bank LIMIT 1")
if err != nil {
c.l.Printf("%s", err)
time.Sleep(time.Second)
continue
}
c.l.Printf("found the table")
break
}

m := newMonitor(ctx, c)
m.Go(func(ctx context.Context) error {
t.Status(`running backup`)
Expand Down

0 comments on commit db52476

Please sign in to comment.