-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evaluation of additional operators #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some minor comments.
I can't think of any place where we would need to add a DeprecationWarning
for the type change from list
to dict
. But maybe the others can think of something.
qiskit/chemistry/qubit_transformations/fermionic_transformation.py
Outdated
Show resolved
Hide resolved
qiskit/chemistry/qubit_transformations/fermionic_transformation.py
Outdated
Show resolved
Hide resolved
qiskit/chemistry/qubit_transformations/qubit_operator_transformation.py
Outdated
Show resolved
Hide resolved
I think that now it looks ok. Should I merge it or are there any other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some leftovers from the dict
-style aux_ops.
qiskit/chemistry/ground_state_calculation/mes_ground_state_calculation.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Max Rossmannek <max.rossmannek@uzh.ch>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
I think the aux op values, like the eigen values - were always complex numbers so far |
Summary
Add the possibility to pass a dictionary of auxiliary operators to
compute_groundstate
andtransform
.Details and comments
{str: FermionicOperator/BosonicOperator}
Any
but could possible beUnion[FermionicOperator, BosonicOperator]
once we have the bosonic operatorOpen questions
MinimumEigensolver
interface also supports aux operators but there they are a list. Since this is a mathematically abstract solver w/o any interpretation it might make sense to keep them as list there. This is what's done now.