Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap is using Qt 5.5.1, the version that comes with Ubuntu Xenial #1439

Closed
pachulo opened this issue Nov 22, 2019 · 12 comments
Closed

Snap is using Qt 5.5.1, the version that comes with Ubuntu Xenial #1439

pachulo opened this issue Nov 22, 2019 · 12 comments
Labels
Importance: Low Type: Improvement improves existing functionality
Milestone

Comments

@pachulo
Copy link
Contributor

pachulo commented Nov 22, 2019

Expected behaviour

As far as I can see here:

Snap should be build using base: core18, and its corresponding Qt version: 5.9.5

Actual behaviour

The snap is still using Qt 5.5.1, the version included in Ubuntu Xenial:

Am I missing something?

Thanks!

@pbek
Copy link
Owner

pbek commented Nov 22, 2019

Currently there are two snap releases in parallel:

  1. https://code.launchpad.net/~pbek/+snap/qownnotes that uses https://github.com/pbek/QOwnNotes/blob/develop/build-systems/snap/snapcraft/snapcraft.yaml is used for releases and only supports Core 16
  2. https://build.snapcraft.io/user/pbek that uses https://github.com/pbek/QOwnNotes/blob/develop/snap/snapcraft.yaml doesn't support automatic releasing and is only used in the edge channel.

@pbek
Copy link
Owner

pbek commented Nov 22, 2019

If there is a way to make 2) support automatic releases to the stable channel for anything that is pushed to the master git branch I'm all ears.

@pbek
Copy link
Owner

pbek commented Nov 22, 2019

But it also would need the have the correct version number inserted like in 1).

@pachulo
Copy link
Contributor Author

pachulo commented Nov 30, 2019

I'm not really sure I understand the problem with option (1...why do you say it does not support core18? I mean, even if it does not appear as an option when building snaps, if the snapcraft.yaml uses the base: core18 and the “Series” option is set to “Ubuntu Bionic, for Ubuntu Core 16” everything should be fine.

@pbek
Copy link
Owner

pbek commented Dec 1, 2019

if the snapcraft.yaml uses the base: core18 and the “Series” option is set to “Ubuntu Bionic, for Ubuntu Core 16” everything should be fine.

are you sure that works with Launchpad? you still only can select the core 16 and last time I used another ubuntu version the snap didn't build because they Canonical didn't added support for the other selections yet.

Screenshot 2019-12-01 at 06 36 45

@pachulo
Copy link
Contributor Author

pachulo commented Dec 1, 2019

Yeah, pretty sure; I'm using it for 2 snaps. More info:

@pbek
Copy link
Owner

pbek commented Dec 1, 2019

That is awesome, I will try that, thank you very much! 👍🏻

@pbek pbek added Type: Improvement improves existing functionality Importance: Low and removed Type: Support labels Dec 2, 2019
@pbek pbek added this to the 19.12.1 milestone Dec 2, 2019
pbek added a commit that referenced this issue Dec 3, 2019
pbek added a commit that referenced this issue Dec 3, 2019
@pbek
Copy link
Owner

pbek commented Dec 3, 2019

19.12.1

  • attempted to switch to Core18 for the snap release on Launchpad

@pbek
Copy link
Owner

pbek commented Dec 3, 2019

There now is a new release, could you please test it and report if it works for you?

@pbek
Copy link
Owner

pbek commented Dec 3, 2019

Great, Core18 is working for me. Thanks again for the heads up!

General Info

Current Date: Di. Dez. 3 21:43:26 2019
Version: 19.12.1
Build date: Dec 3 2019
Build number: 630
Platform: linux
Operating System: Ubuntu Core 18
Build architecture: x86_64
Current architecture: x86_64
Release: Snapcraft
Qt Version (build): 5.9.5
Qt Version (runtime): 5.9.5

@pbek pbek closed this as completed Dec 3, 2019
@pachulo
Copy link
Contributor Author

pachulo commented Dec 4, 2019

Great! Now that this is on place maybe we can make it look better, doing something similar to what they did here:

If I have some time I will be proposing the fixes soon.

Thanks to you for this software!

@pbek
Copy link
Owner

pbek commented Dec 4, 2019

Great! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Importance: Low Type: Improvement improves existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants