-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong behavior of the search function when filtering by TAGs if there are notes with the same name. #1686
Comments
Thank you for reporting, I will try to reproduce your issue. |
If you want to provide a complete note folder to reproduce what you did that would help a lot. |
Ok. I added explanations in every note, to help you understand the behavior. |
Thank you. And can you please post the output from the debug settings (see issue template). |
I hope this is what you were asking. QOwnNotes Debug InformationGeneral InfoCurrent Date: Server InfoserverUrl: empty SpellcheckingEnabled: Note folderscurrentNoteFolderId: Note folder
|
Yes, thank you, plus this: 😁
|
I didn't post the log before 'cause I didn't find anything useful in it. Anyway.. here's my log: [apr 13 07:12:12] [warning]: "Removed log file: " "K:/QOwnNotes [portable]/Data/QOwnNotes.log" |
I'm not sure if it's a regression or simply never worked. Tag filtering is currently only checking file names in |
Will be hard to implement (because of the way we need to store the tagging data), I'm taking a look at it. |
Yes.. that's exactly the wrong behavior I noticed. Instead it should only list one note as result, the "Test.md" in the Alpha sub-folder, the only one that has been tagged with the "test tag". 👍 |
Maybe this is it's the first time someone is using tags so consistently and intensively. I need them. I usually keep TONS of notes and tags are mandatory if you need a fast and efficient way to sort things out. |
My brain has knots now. 😅 20.4.6
|
There now is a new release, could you please test it and report if it works for you? |
You're amazing!!! Tested right now.. and it seems that everything is working as it should!!!!! Thank you again!!! 👍 |
Great, thank you for testing! 😁 |
If you have the "use sub-folders" option enabled and you have 2 or more notes with the same name (in different sub-folders, obviously) the search function though a specific tag lists EVERY note with the same name even if it's not tagged with that tag (or not tagged at all).
I'll try to describe this issue with a simple example: I have 3 sub-folders (Alpha, Beta, Gamma) into my base note folder; each sub-folder contains a note with the same name (test.md).
If I assign the tag "TestTag" to only one of this three different test.md notes - and only to one - the tag filter search function with "TestTag" selected lists as result all the three files (with the same name) as they've been tagged with the "TestTag" but two of them are not.
The text was updated successfully, but these errors were encountered: