Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ignoring absent Note-Folders #3179

Closed
Tearony opened this issue Dec 12, 2024 · 9 comments
Closed

[FEATURE] Ignoring absent Note-Folders #3179

Tearony opened this issue Dec 12, 2024 · 9 comments
Labels
Milestone

Comments

@Tearony
Copy link

Tearony commented Dec 12, 2024

Instead of prompting you to select another folder, the active notes folder should just switch to the next existing folder.

Alternative: give a warning "folder not available, switch to..."

@pbek
Copy link
Owner

pbek commented Dec 12, 2024

A little more context, please. 😉

Can you please describe what you expected, what the actual behavior was, and step by step what you did?

@Tearony
Copy link
Author

Tearony commented Dec 12, 2024

I am using VeraCrypt and have a notefolder in an encrypted Volume. If the last selected Folder is not found, I am asked to select an alternative Folder and i cannot open the program and use another folder without selecting.

What I did:

  1. Use a Notefolder, that is on a VeraCrypt Volume
  2. close QOwnNotes (not changing the notefolder)
  3. disconnect VeraCrypt Volume
  4. Open QOwnNotes

What I get:
grafik
(Path to note folder is black)

If I press No / Nein, QOwnNotes closes
If I press Yes I can change the notefolder

What I would like to get:
Either just a warning and then being able to use another notefolder
Or just by default (if the folder isn't found) going to a specific notefolder

@pbek
Copy link
Owner

pbek commented Dec 12, 2024

So you have multiple note folders? (You never shared the settings dump, like advised in the issue template.)

@pbek pbek added Type: Feature adds functionality Importance: Low and removed Type: Support labels Dec 12, 2024
@pbek
Copy link
Owner

pbek commented Dec 12, 2024

It's a bit tricky, because the note folder references are stored in a database and that check is done even before those tables are loaded... 🤔

pbek added a commit that referenced this issue Dec 12, 2024
…nt note folder is gone

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
@pbek
Copy link
Owner

pbek commented Dec 12, 2024

24.12.3

  • If the current note folder doesn't exist anymore during the start of the
    application, now the first existing one will be selected (for #3179)
    • If there was only one note folder, the user needs to select a new path
    • When the application is already running and a note folder was removed outside
      the application, the user will now get a warning that the path doesn't exist
      anymore and is not able to select that note folder

@pbek pbek added this to the 24.12.3 milestone Dec 12, 2024
@pbek
Copy link
Owner

pbek commented Dec 12, 2024

There now is a new release, could you please test it and report if it works for you?

@Tearony
Copy link
Author

Tearony commented Dec 12, 2024

Downloaded it and it worked so far,

What I tried:
Using my existing notes-folder that is in a VeraCrypt Container, closing QOwnNotes, disconnecting the container and reopening QOwnNotes
Also tried creating a new folder on an external USB device (I know it shouldn't be different) and it worked to

Thats what I was searching for, thank you very much

@pbek
Copy link
Owner

pbek commented Dec 12, 2024

Great it works! 😊 Thank you for testing.

@pbek pbek closed this as completed Dec 12, 2024
pbek added a commit that referenced this issue Dec 20, 2024
Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>
@pbek
Copy link
Owner

pbek commented Dec 20, 2024

24.12.4

  • The welcome wizard will now be shown again when the application runs for the first time,
    this was a regression from 24.12.3 (for #3179)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants