Add multiple folder selection to view notes in all selected folders[WIP] #1463
Conversation
| while (*it) { | ||
| // hide all notes that are not in selection | ||
| if (!noteIdList.contains((*it)->data(0, Qt::UserRole).toInt())) { | ||
| (*it)->setHidden(true); |
There was a problem hiding this comment.
You cannot simply show or hide notes in the list. Don't forget about everything MainWindow::filterNotes() does! 😄
There was a problem hiding this comment.
Really? 🤔
But it does hide notes, and shows the ones from the selected folders 🤔
I don't know the implications this will have for all other modules though and the side effects...
MainWindow::filterNotes() would require a lot of changes to work with multi folder selection, right? or maybe I didn't understand you
There was a problem hiding this comment.
You can always for example also search for text at the same time, working with MainWindow::filterNotes() is mandatory or you will immediately get bug reports. 😬
There was a problem hiding this comment.
Your new filters need to be part of the MainWindow::filterNotes() filtering process.
There was a problem hiding this comment.
You can always for example also search for text at the same time, working with
MainWindow::filterNotes()is mandatory or you will immediately get bug reports. grimacing
I just tried this.
Multi select + search in noteTreeWidget. Works, but if you delete the searched text, the selection isn't retained.
There was a problem hiding this comment.
Need more time to test that again, maybe tomorrow. I'm out the whole day today. 😬
There was a problem hiding this comment.
Do you maybe have the 'recursive tagging' setting on? thinking
yes
Multiple sub-folders selected. Clicking on tags didn't change the note list.
There was a problem hiding this comment.
I am sorry, I tested one more time and didn't have the issue, I guess tray icon support shot me in the leg (an old version of the app may not have been closed). 😬
There was a problem hiding this comment.
Cool. One more feature down. 🥇 😁
#327