Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement filtering by multiple tags #1481

Merged
merged 3 commits into from
Dec 5, 2019
Merged

Implement filtering by multiple tags #1481

merged 3 commits into from
Dec 5, 2019

Conversation

Waqar144
Copy link
Contributor

@Waqar144 Waqar144 commented Dec 5, 2019

@coveralls
Copy link

coveralls commented Dec 5, 2019

Coverage Status

Coverage decreased (-0.01%) to 10.836% when pulling 5f9bba7 on Waqar144:mul-tags into 9033dab on pbek:develop.

@pbek pbek added the WIP PR that is still being worked on label Dec 5, 2019
@pbek
Copy link
Owner

pbek commented Dec 5, 2019

I knew you will take tags up too! 😁
Doesn't seem to work in every situation for me when unselecting tags.

https://imgur.com/a/6fKXtNO

@pbek
Copy link
Owner

pbek commented Dec 5, 2019

After single selecting I selected two tags, that worked. But when un-selecting tags notes wasn't filtered correctly. I guess that's because only one tag was selected any more and I clicked on the tag that I wanted un-selected. I don't know how to get around this. 😬

@Waqar144
Copy link
Contributor Author

Waqar144 commented Dec 5, 2019

I knew you will take tags up too! grin
Doesn't seem to work in every situation for me when unselecting tags.

https://imgur.com/a/6fKXtNO

It seemed pretty straightforward after I looked into it 😆

@Waqar144
Copy link
Contributor Author

Waqar144 commented Dec 5, 2019

After single selecting I selected two tags, that worked. But when un-selecting tags notes wasn't filtered correctly. I guess that's because only one tag was selected any more and I clicked on the tag that I wanted un-selected. I don't know how to get around this. grimacing

Fixed, I think

@pbek
Copy link
Owner

pbek commented Dec 5, 2019

Awesome!

@pbek pbek merged commit a6dcd75 into pbek:develop Dec 5, 2019
@Waqar144 Waqar144 deleted the mul-tags branch December 8, 2019 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP PR that is still being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants