Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch data source for the buoys that are no longer being updated #33

Open
andrew-edwards opened this issue Aug 16, 2023 · 2 comments
Open
Assignees
Labels
priority Issue to do next

Comments

@andrew-edwards
Copy link
Member

Compare with Andrea's plots - looks like some of the DFO-based ones are not getting updated now, so switch data-raw code to use the ECCC ones for those.

@andrew-edwards andrew-edwards self-assigned this Aug 16, 2023
andrew-edwards added a commit that referenced this issue Aug 28, 2023
@andrew-edwards
Copy link
Member Author

Leaving open as still want to compare the SST for when the DFO and ECCC data overlap. For example, for buoy C46146 it looks like (when comparing plots on the vignette before/after redoing data) some of the previous years may have changed? Can test by making plot, reverting above commit, making plot again.

@andrew-edwards
Copy link
Member Author

andrew-edwards commented Aug 30, 2023

  • In data-raw code, change opp to eccc since now we're not just using the two opp buoys from eccc data source.
  • Incorporate the flags for ECCC data. @schckngs to look into a little first, Andy can do some checking also. Hadn't used them before since just the opp data. See Update q/c on the ECCC data and make sure the daily spikes are removed IOS-OSD-DPG/Pacific_SST_Monitoring#2
  • Check if that automatically eliminates the dodgy looking data for which we concluded the buoy was probably switched on then lay on the deck of a boat for a few days.
  • Also allow two weeks for the buoys to be in the water (though maybe not needed once we include the flags); so maybe change the switch_dfo_to_opp value.
  • Andrea had checked overlapping times and found DFO and ECCC data to agree. Andy can do a quick check once we've used the flags.
  • Add to help that buoy SST is actually 1 m depth. And the satellite data are calibrated to also be 1 m, and OI SST actually incorporates buoy SST (i.e. not totally independent data sources - important, and others hadn't realised that for a while). Also ROMS SST is the top box of the grid, < 1m, maybe down to 0.2 m I think.

@andrew-edwards andrew-edwards added the for Version 1.0.0.0 Needs completing before official release label Oct 23, 2023
@andrew-edwards andrew-edwards added priority Issue to do next and removed for Version 1.0.0.0 Needs completing before official release labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Issue to do next
Projects
None yet
Development

No branches or pull requests

1 participant