-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Optimise erc1155
NoBackdoor
halmos
Test
#255
Conversation
…s for burn_batch() and set_uri()
performance profile on MacBook M1 Pro with 16GB RAM: ERC1155TestHalmos:
ERC721TestHalmos:
|
NoBackdoor
halmos
Tests
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
NoBackdoor
halmos
TestsNoBackdoor
halmos
Test
NoBackdoor
halmos
Testerc1155
NoBackdoor
halmos
Test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx a lot for this @daejunpark! I did a small clean-up here: e597e1c and moved the halmos
CI to a cron job since erc721
is taking way to long to be integrated into the normal PR pipeline. Any ideas on how to optimise erc721
further?
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
🕓 Changelog
This PR uncomments the
erc721
anderc1155
NoBackdoor
halmos
tests and optimises theerc1155
NoBackdoor
halmos
test. In addition, we remove thetest-parallel
flag in thehalmos
configuration, because if bothtest-parallel
andsolver-parallel
are enabled, the (peak) number of parallel solver processes could be too high, which could affect performance. Theerc721
halmos
tests take substantial amount of time as part of the CI. Henceforth, we run thehalmos
CI pipeline each day at 03:30 a.m. (= "nightly" tests) as scheduledcron
job instead of integrating it into the normalpush
andpull_request
pipeline.🐶 Cute Animal Picture