-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Use Native Hex String x"..."
Literals
#283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
added
dependencies 🔁
Pull requests that update a dependency file
refactor/cleanup ♻️
Code refactorings and cleanups
labels
Oct 12, 2024
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
pcaversaccio
changed the title
♻️ Use Native Hex
♻️ Use Native Hex String Oct 12, 2024
x"..."
String Literalsx"..."
Literals
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies 🔁
Pull requests that update a dependency file
feature 💥
New feature or request
refactor/cleanup ♻️
Code refactorings and cleanups
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🕓 Changelog
Vyper has introduced support for native hex string literals, such as
x"a1b9"
(see PR #4271). This update refactors the 🐍 snekmate contracts—base64
andmessage_hash_utils
—to take advantage of the new syntax. However, theinternal
function_to_eth_signed_message_hash
remains unchanged, as its current implementation with\x19
provides better clarity. Moreover, theexternal
functioneip712Domain
in theeip712_domain_separator
contract has been simplified to utilise abytes1
literal. Additionally, all submodules have been updated to their latest commits, and the latest Vypermaster
commit is now once again applied in allvenom
-based tests, following the resolution of issue #4288 through this commit.🐶 Cute Animal Picture