Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Use Native Hex String x"..." Literals #283

Merged
merged 10 commits into from
Oct 18, 2024

Conversation

pcaversaccio
Copy link
Owner

@pcaversaccio pcaversaccio commented Oct 12, 2024

🕓 Changelog

Vyper has introduced support for native hex string literals, such as x"a1b9" (see PR #4271). This update refactors the 🐍 snekmate contracts—base64 and message_hash_utils—to take advantage of the new syntax. However, the internal function _to_eth_signed_message_hash remains unchanged, as its current implementation with \x19 provides better clarity. Moreover, the external function eip712Domain in the eip712_domain_separator contract has been simplified to utilise a bytes1 literal. Additionally, all submodules have been updated to their latest commits, and the latest Vyper master commit is now once again applied in all venom-based tests, following the resolution of issue #4288 through this commit.

🐶 Cute Animal Picture

image

Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio self-assigned this Oct 12, 2024
@pcaversaccio pcaversaccio added dependencies 🔁 Pull requests that update a dependency file refactor/cleanup ♻️ Code refactorings and cleanups labels Oct 12, 2024
@pcaversaccio pcaversaccio added this to the 0.1.1 milestone Oct 12, 2024
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio changed the title ♻️ Use Native Hex x"..." String Literals ♻️ Use Native Hex String x"..." Literals Oct 12, 2024
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio added the feature 💥 New feature or request label Oct 12, 2024
pcaversaccio and others added 6 commits October 15, 2024 11:28
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: sudo rm -rf --no-preserve-root / <pcaversaccio@users.noreply.github.com>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
@pcaversaccio pcaversaccio merged commit d512351 into main Oct 18, 2024
14 of 15 checks passed
@pcaversaccio pcaversaccio deleted the feat/native-hex-strings branch October 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies 🔁 Pull requests that update a dependency file feature 💥 New feature or request refactor/cleanup ♻️ Code refactorings and cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant