WIP : Add chocolatey support #237

hdep · 2020-01-08T16:57:17Z

No description provided.

manifests/params.pp

manifests/init.pp

pcfens · 2020-01-10T03:08:30Z

Thanks for all the work on this so far. I've added a few comments on what you've done so far, but this is significantly more then I would have been able to set up.

hdep · 2020-01-11T15:04:40Z

hi @pcfens I did the change you asked. Can you please review them ? Thanks !

manifests/init.pp

pcfens · 2020-01-13T23:03:40Z

Looks great. If you have time, could you add the new parameters to the comments in init.pp and to the README? A note that package_provider is ignored unless you're on a Windows box would be helpful too. If you're running out of time I'm happy to add both of those too.

Thanks for putting all of this together. As soon as you drop the WIP flag I'm happy to merge it.

hdep · 2020-01-15T10:32:43Z

If this version is ok for you, last thing to do is to test on a windows box.

pcfens · 2020-01-17T16:19:22Z

Thanks a ton for putting this together. I don't have access to a good setup to test - do you?

If not, we can probably merge whenever since the changes won't break existing installs (I'll just add a note that chocolatey support is experimental or something).

hdep · 2020-01-18T13:36:06Z

I do have windows server so I'll be able to test as soon as I've got some time.
But yeah if you are not afraid you can merge and i'll test with master :)

hdep · 2020-01-20T12:41:30Z

I just run one test : it fails beause by default we set 7.1.0 for package_ensure, but this version doesn't exist in chocolatey repository.

either we upgrade the value of 7.1.0 to something like 7.2.0 or I need to set a case statement in params.pp

what do you prefer ?

Here is the available release :
https://chocolatey.org/packages/filebeat#versionhistory

hdep · 2020-01-20T13:17:14Z

Last but not least, chocolatey install the package into C:\ProgramData\chocolatey\lib\filebeat\tools by default, hence we need to manage this as well. I'll give a look if I can specify specific value when using chocolatey

manifests/params.pp

pcfens · 2020-01-21T22:10:27Z

Thanks for all your work on this - I'm sorry we keep running in to little things.

Feel free to update the default to 7.2.0 (or latest, I imagine most folks set some value).

hdep · 2020-01-22T09:29:45Z

this code doesn't work. The if statement return false, I don't understand why.
So the path are wrong :

Info: Applying configuration version '1579685172'
Error: Cannot create C:/Program Files/Filebeat/conf.d; parent directory C:/Program Files/Filebeat does not exist
Error: /Stage[main]/Filebeat::Config/File[filebeat-config-dir]/ensure: change from 'absent' to 'directory' failed: Canno
t create C:/Program Files/Filebeat/conf.d; parent directory C:/Program Files/Filebeat does not exist (corrective)
Notice: /Stage[main]/Filebeat::Config/File[filebeat.yml]: Dependency File[filebeat-config-dir] has failures: true
Warning: /Stage[main]/Filebeat::Config/File[filebeat.yml]: Skipping because of failed dependencies
Warning: /Stage[main]/Profiles::Base::Windows/Filebeat::Input[syslog]/File[filebeat-syslog]: Skipping because of failed
dependencies
Warning: /Stage[main]/Filebeat::Service/Service[filebeat]: Skipping because of failed dependencies
Warning: /Stage[main]/Filebeat/Anchor[filebeat::end]: Skipping because of failed dependencies
Notice: Applied catalog in 33.87 seconds

pcfens · 2020-01-22T16:52:54Z

I'm not sure that conditional defaults are possible since params.pp is evaluated before the init.pp. I think the logic might have to be implemented either in init.pp or in the install/windows.pp file.

I've seen this done before by setting all of the values to undef, then checking them later on (kind of like we're doing for the download URL)

This reverts commit 9041e51

hdep · 2020-02-03T08:49:01Z

Hi @pcfens I've working hard trying to make this work, but I'm stuck. I'm not able to manage properly the path file for Chocolatey. Any help are more than welcome.

Thanks

ferventcoder · 2020-02-09T19:12:56Z

manifests/init.pp

@@ -100,11 +102,17 @@
  Optional[String] $systemd_beat_log_opts_override                    = undef,
  String $systemd_beat_log_opts_template                              = $filebeat::params::systemd_beat_log_opts_template,
  String $systemd_override_dir                                        = $filebeat::params::systemd_override_dir,
-
+  Variant[String, Enum['exec', 'chocolatey']] $package_provider       = undef,


Interesting, I would expect this to use exec by default as one of the params. $filebeat::params::package_provider, but I can see why maybe not drop it into the params since it would not be platform agnostic

Yes I want exec by default and chocolatey as an option. Not sure what I can do here ? I want to let the choice to the user. what do you recommend ?

ferventcoder · 2020-02-09T19:20:54Z

manifests/input.pp

+        $filebeat_path = join([$cmd_install_dir, 'Filebeat', 'filebeat.exe'], '\\')
+      }
+      else {
+        $filebeat_path = 'C:/ProgramData/chocolatey/lib/filebeat/tools/filebeat.exe'


"$env:ChocolateyInstall/bin/filebeat.exe" (needs ruby code for environment) - also I'm pointing to the shim in the bin folder, but you can stick with lib if you want.

ferventcoder · 2020-02-09T19:25:04Z

I would like to see source be a possibility as most folks using Puppet are not likely to be using the community repo (the default). However, If they've already configured default sources, then choco will just use those - so not being explicit has a way to just work. 👍

hdep · 2020-02-20T08:59:30Z

Hi @ferventcoder thanks, my main issue is that I'm not able to make $package_provider by default exec and switch to chocolatey if specified.

In my test environment it just fail to run with chocolatey.

hdep · 2020-04-08T09:25:25Z

Hi,

i've been debuging this. It doesn't works because params.pp is evaluated first (init.pp herits from params.pp).
I don't know yet how to do manage this.
Any idea are more than welcome !

hdep · 2020-04-15T07:47:06Z

I close this ins favor of #247

pcfens reviewed Jan 10, 2020

View reviewed changes

manifests/params.pp Outdated Show resolved Hide resolved

pcfens reviewed Jan 10, 2020

View reviewed changes

manifests/init.pp Outdated Show resolved Hide resolved

pcfens reviewed Jan 10, 2020

View reviewed changes

manifests/init.pp Outdated Show resolved Hide resolved

hdep force-pushed the choco branch 2 times, most recently from f59c21f to 583fedf Compare January 11, 2020 14:54

pcfens reviewed Jan 13, 2020

View reviewed changes

manifests/init.pp Show resolved Hide resolved

This was referenced Jan 13, 2020

Support for elastic-oss #177

Open

offline installation of filebeat #19

Closed

hdep force-pushed the choco branch from b253e4d to cd9cc86 Compare January 15, 2020 09:51

hdep force-pushed the choco branch from 428206c to 9c433fa Compare January 20, 2020 13:24

Add chocolatey support

d88ad72

hdep force-pushed the choco branch from 9c433fa to d88ad72 Compare January 20, 2020 13:33

Debug

dc8eeea

pcfens reviewed Jan 21, 2020

View reviewed changes

manifests/params.pp Outdated Show resolved Hide resolved

use local variable

aedb19c

hdep added 4 commits February 1, 2020 10:14

Debug choco

9041e51

Debug choco

2b9e8f6

Debug choco

2a3aab7

Revert "Debug choco"

9dd5b27

This reverts commit 9041e51

hdep and others added 13 commits February 1, 2020 11:22

Debug choco

c98705b

debug

187a7c7

debug

6a4be17

debug

e9ba086

debug

f839301

debug

a96d606

manage chocolatey path

a19bea8

fix syntax

0fe7af1

fix package provider

04b7bf2

use real_package_provider

a12c8d2

use real_package_provider

99c6a04

fix style

9ddbe46

manage real_package_provider

65bce6d

ferventcoder reviewed Feb 9, 2020

View reviewed changes

hdep closed this Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP : Add chocolatey support #237

WIP : Add chocolatey support #237

hdep commented Jan 8, 2020

pcfens commented Jan 10, 2020

hdep commented Jan 11, 2020

pcfens commented Jan 13, 2020

hdep commented Jan 15, 2020

pcfens commented Jan 17, 2020

hdep commented Jan 18, 2020

hdep commented Jan 20, 2020 •

edited

Loading

hdep commented Jan 20, 2020

pcfens commented Jan 21, 2020

hdep commented Jan 22, 2020

pcfens commented Jan 22, 2020

hdep commented Feb 3, 2020

ferventcoder Feb 9, 2020

hdep Feb 20, 2020

ferventcoder Feb 9, 2020

ferventcoder commented Feb 9, 2020

hdep commented Feb 20, 2020

hdep commented Apr 8, 2020

hdep commented Apr 15, 2020

WIP : Add chocolatey support #237

WIP : Add chocolatey support #237

Conversation

hdep commented Jan 8, 2020

pcfens commented Jan 10, 2020

hdep commented Jan 11, 2020

pcfens commented Jan 13, 2020

hdep commented Jan 15, 2020

pcfens commented Jan 17, 2020

hdep commented Jan 18, 2020

hdep commented Jan 20, 2020 • edited Loading

hdep commented Jan 20, 2020

pcfens commented Jan 21, 2020

hdep commented Jan 22, 2020

pcfens commented Jan 22, 2020

hdep commented Feb 3, 2020

ferventcoder Feb 9, 2020

Choose a reason for hiding this comment

hdep Feb 20, 2020

Choose a reason for hiding this comment

ferventcoder Feb 9, 2020

Choose a reason for hiding this comment

ferventcoder commented Feb 9, 2020

hdep commented Feb 20, 2020

hdep commented Apr 8, 2020

hdep commented Apr 15, 2020

hdep commented Jan 20, 2020 •

edited

Loading