Strong type the airtable record dict. #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcorpet
approved these changes
Sep 9, 2020
airtable/airtable.pyi
Outdated
| offset: Optional[int] = None, | ||
| filter_by_formula: Optional[str] = None, | ||
| view: Optional[str] = None) \ | ||
| -> Dict[str, List[_Record]]: |
There was a problem hiding this comment.
Please move on the line above now that it's short enough.
zozoens31
force-pushed
the
cyrille-types
branch
from
15ff8e4
to
8748cab
Compare
zozoens31
commented
Sep 11, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pcorpet)
airtable/airtable.pyi, line 60 at r1 (raw file):
Previously, pcorpet (Pascal Corpet) wrote…
Please move on the line above now that it's short enough.
Done.
pcorpet
approved these changes
Sep 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is