Add desc to component type #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pd4d10
reviewed
Aug 15, 2024
| @@ -5,7 +5,7 @@ declare module "*.svg?react" { | |||
| import * as React from "react"; | |||
|
|
|||
| const ReactComponent: React.FunctionComponent< | |||
| React.ComponentProps<"svg"> & { title?: string } | |||
| React.ComponentProps<"svg"> & { title?: string, titleId?: string, desc?: string, descId?: string } | |||
There was a problem hiding this comment.
Thanks for your contribution!
It's only for type. Should the implementation be updated to make it work?
There was a problem hiding this comment.
Currently only jsx plugin is used. Not quite sure if other plugins should be applied to support this feature
Line 29 in e4a770b
There was a problem hiding this comment.
@pd4d10 I'm not sure what you mean. The feature already works, I think the typescript error is the only problem.
pd4d10
approved these changes
Nov 1, 2024
|
Sorry for the late response. Thank you! Published v4.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
descprop (gregberge/svgr#729) to the component type.Closes #116