Drop the iteration limit from 40k to max(400,20n).

pdeyhim · Apr 21, 2014 · 0cb4481 · 0cb4481
1 parent e2a01d1
commit 0cb4481
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/mllib/src/main/scala/org/apache/spark/mllib/optimization/NNLSbyPCG.scala b/mllib/src/main/scala/org/apache/spark/mllib/optimization/NNLSbyPCG.scala
@@ -99,11 +99,12 @@ private[mllib] object NNLSbyPCG {
     val dir = ws.dir
     val lastDir = ws.lastDir
     val res = ws.res
+    val iterMax = Math.max(400, 20 * n)
     var lastNorm = 0.0
     var iterno = 0
     var lastWall = 0 // Last iteration when we hit a bound constraint.
     var i = 0
-    while (iterno < 40000) {
+    while (iterno < iterMax) {
       // find the residual
       SimpleBlas.gemv(1.0, ata, x, 0.0, res)
       SimpleBlas.axpy(-1.0, atb, res)