Skip to content

Commit

Permalink
SPARK-1583: Fix a bug that using java.util.HashMap by mistake
Browse files Browse the repository at this point in the history
JIRA: https://issues.apache.org/jira/browse/SPARK-1583

Does anyone know why using `java.util.HashMap` rather than `mutable.HashMap`? Some methods of `java.util.HashMap` are not generics and compiler can not help us find similar problems.

Author: zsxwing <zsxwing@gmail.com>

Closes apache#500 from zsxwing/SPARK-1583 and squashes the following commits:

7bfd74d [zsxwing] SPARK-1583: Fix a bug that using java.util.HashMap by mistake
  • Loading branch information
zsxwing authored and pdeyhim committed Jun 25, 2014
1 parent 4f43b23 commit 883c38f
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,7 @@ class BlockManagerMasterActor(val isLocal: Boolean, conf: SparkConf, listenerBus
val locations = blockLocations.get(blockId)
locations -= blockManagerId
if (locations.size == 0) {
blockLocations.remove(locations)
blockLocations.remove(blockId)
}
}
listenerBus.post(SparkListenerBlockManagerRemoved(blockManagerId))
Expand Down

0 comments on commit 883c38f

Please sign in to comment.