Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyproject.toml (using hatchling) #1028

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dhdaines
Copy link
Contributor

@dhdaines dhdaines commented Jul 31, 2024

Pull request

Switch to pyproject.toml. I used hatch or more specifically its build backend hatchling because it was convenient, but we could also use plain old setuptools if you prefer! Fixes #931

How Has This Been Tested?

hatch run build
hatch shell
pip install -e .[dev]
nox

Checklist

  • [x ] I have read CONTRIBUTING.md.
  • [x ] I have added a concise human-readable description of the change to CHANGELOG.md.
  • [x ] I have tested that this fix is effective or that this feature works.
  • [x ] I have added docstrings to newly created methods and classes.
  • [x ] I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@dhdaines
Copy link
Contributor Author

Note that the output sdist and wheels end up being named pdfminer_six-... and not pdfminer.six-.... This is probably a good thing but I don't know if it will cause problems for PyPI?

@dhdaines
Copy link
Contributor Author

dhdaines commented Aug 6, 2024

The test failure above is some random GitHub failure, not an actual problem with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to pyproject.toml
1 participant